-
Notifications
You must be signed in to change notification settings - Fork 0
Fix _config.yml duplicate keys; add projects collection; create two sample project items; list projects on /projects/ page #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ample project items; list projects on /projects/ page
Reviewer's GuideThis PR consolidates duplicate key definitions in the Jekyll config, adds a new 'projects' collection with routing, implements a listing template on the /projects/ page, and provides two sample project entries to bootstrap the new collection. Entity relationship diagram for new 'projects' collection in Jekyll siteerDiagram
PROJECTS {
string title
string summary
string status
string permalink
string layout
}
PROJECTS ||--o| PAGES : "listed on"
PAGES {
string title
string permalink
string layout
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- The projects collection permalink is defined using :name but your sample items only set title in their front matter—either switch the permalink to :title or add a name field to avoid broken URLs.
- There's a leftover commented-out exclude block under defaults in _config.yml that’s now redundant—consider removing it to keep the config clean.
- On the /projects/ page, you might add an empty-state message or placeholder when no projects exist to improve the user experience.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The projects collection permalink is defined using :name but your sample items only set title in their front matter—either switch the permalink to :title or add a name field to avoid broken URLs.
- There's a leftover commented-out exclude block under defaults in _config.yml that’s now redundant—consider removing it to keep the config clean.
- On the /projects/ page, you might add an empty-state message or placeholder when no projects exist to improve the user experience.
## Individual Comments
### Comment 1
<location> `_config.yml:89-91` </location>
<code_context>
poetry:
output: true
permalink: /:collection/:title/
+ projects:
+ output: true
+ permalink: /projects/:name/
# Plugins (preferred order: remote theme first)
</code_context>
<issue_to_address>
**question:** Check consistency of permalink structure for new 'projects' collection.
Confirm that all project items include a 'name' field, or switch to ':title' for consistency unless a distinct reason exists for using ':name'.
</issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
projects: | ||
output: true | ||
permalink: /projects/:name/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Check consistency of permalink structure for new 'projects' collection.
Confirm that all project items include a 'name' field, or switch to ':title' for consistency unless a distinct reason exists for using ':name'.
…ief + keep collection listing; add six blog drafts
Summary by Sourcery
Add and configure a new 'projects' collection by cleaning up '_config.yml', implement a listing page at '/projects/', and include two example project items
New Features:
Bug Fixes: